![Piotr Jastrzebski Profile](https://pbs.twimg.com/profile_images/1631206940373073920/ykYJZX_S_x96.jpg)
Piotr Jastrzebski
@haaawk_dev
Followers
214
Following
3K
Statuses
189
Joined February 2023
@isburmistrov @penberg Yes. This is the same in terms of splitting the work. Whether you keep multiple commits per PR or do 1 commit per PR, what matters most is that you have those commits separated.
0
0
0
@souper_deluxe @penberg When I developed @Android and @googlechrome, history was extremely valuable. With avg turnover at Google being ~2 years, good history is all we have :)
0
0
0
@ospfranco Yeah. I think stacked PRs are a good solution, assuming each PR is as small as possible - within reason.
0
0
1
@isburmistrov @penberg This is a problem. One can make sure every commit compiles and passes tests without CI, but it's obviously more work. While lack of tooling support is an important argument, it does not change the fact that long-term codebase with good commits is better off.
0
0
0
@isburmistrov @penberg I can't disagree with that :). If you can do PRs which are of the size of a single well defined commit then it's perfect. The result is the same as bigger PR with good commits but is integrated sooner and more often which is great.
1
0
0
@isburmistrov @penberg Git is just a tool. One can split work into good commits without using git rebase. It's just more work :)
0
0
0
@isburmistrov @penberg I don't think this is a good parallel. Vim benefits only the writer and only at edition time. Good commits benefit the whole team at read time and debug time.
0
0
0
@isburmistrov @penberg In my experience, well separated commits are worth the work. Bisect is such a useful tool, and it's much more useful when commits are not huge. It is also much easier for me to review a change that's well laid out and not a big blob of loosely related modifications.
1
0
0
@DomainerRyan @raphael_scarv @penberg Does it work well for people who work with you and have to review your code? :)
0
0
0
@isburmistrov @penberg What I meant was the work it takes to keep the commits tidy. Git rebase -i just happens to be the most popular tool to achieve it. Sorry for not being clear. My understanding is that squashing is just easier and less work than keeping the commits well separated.
1
0
0